1

Closed

Issue with globally excluded files if there are no locally excluded files

description

hi all,
 
i have found a bug in file 'BuildCopEngine.cs'. The method GetBuildFiles() adds globally excluded files information to the excluded list by adding a semicolone first.
 
If however the field is empty, the exclusion information starts with a semicolone which is wrong. Have a look at the code:
 

 
 
string excludedFiles = pathConfiguration.ExcludedFiles;
if (!string.IsNullOrEmpty(buildFilesConfiguration.ExcludedFiles))
{
// Append the globally excluded files.
excludedFiles += ExclusionSeparator + buildFilesConfiguration.ExcludedFiles;
}
I have changed the code like this:
string excludedFiles = pathConfiguration.ExcludedFiles;
            if (!string.IsNullOrEmpty(buildFilesConfiguration.ExcludedFiles))
            {
                // Append the globally excluded files.
                if (excludedFiles.Equals(String.Empty))
                {
                    excludedFiles += buildFilesConfiguration.ExcludedFiles;
                }
                else
                {
                    excludedFiles += ExclusionSeparator + buildFilesConfiguration.ExcludedFiles;
                }
            }
 
 
 
 
When now i run the console program, the temp-files are excluded and any other file is getting checked.
 

 
bye,
 

 
yb
Closed Jun 20, 2011 at 11:02 AM by jelled

comments

wrote Jun 20, 2011 at 11:02 AM

Resolved with changeset 59715.

wrote Feb 2, 2013 at 5:12 AM

wrote May 15, 2013 at 12:38 AM