BuildCop Work Item Rss Feed

Closed Issue: Issue with globally excluded files if there are no locally excluded files [8381]

jelled — Mon, 20 Jun 2011 11:02:28 GMT

hi all,

i have found a bug in file 'BuildCopEngine.cs'. The method GetBuildFiles() adds globally excluded files information to the excluded list by adding a semicolone first.

If however the field is empty, the exclusion information starts with a semicolone which is wrong. Have a look at the code:

string excludedFiles = pathConfiguration.ExcludedFiles;
if (!string.IsNullOrEmpty(buildFilesConfiguration.ExcludedFiles))
{
// Append the globally excluded files.
excludedFiles += ExclusionSeparator + buildFilesConfiguration.ExcludedFiles;
}
I have changed the code like this:
string excludedFiles = pathConfiguration.ExcludedFiles;
if (!string.IsNullOrEmpty(buildFilesConfiguration.ExcludedFiles))
{
// Append the globally excluded files.
if (excludedFiles.Equals(String.Empty))
{
excludedFiles += buildFilesConfiguration.ExcludedFiles;
}
else
{
excludedFiles += ExclusionSeparator + buildFilesConfiguration.ExcludedFiles;
}
}

When now i run the console program, the temp-files are excluded and any other file is getting checked.

bye,

yb
Comments: Resolved with changeset 59715.

Created Issue: Issue with globally excluded files if there are no locally excluded files [8381]

jelled — Mon, 20 Jun 2011 10:53:49 GMT

Commented Feature: Allow BuildCop to run as an MSBuild task

jelled — Mon, 18 Aug 2008 18:07:20 GMT

Create an MSBuild task that allows BuildCop to run as part of e.g. a daily build in Team Foundation Server.
Comments: Associated with changeset 15163.

Created Feature: Allow BuildCop to run as an MSBuild task

jelled — Mon, 18 Aug 2008 18:04:29 GMT

Create an MSBuild task that allows BuildCop to run as part of e.g. a daily build in Team Foundation Server.